Moreover, all plugins that were translated using Loco began to be displayed only in English!
Plugin Author
Tim W
(@timwhitlock)
I need more details to work out what could possibly be different in 2.6.12.
Please provide an example of a plugin whose translations stopped displaying, and the locations of all its translation files.
Good afternoon. Thanks for the answer, the problem occurs with the Paid Memberships Pro plugin. It works great with WordPress 6.7 and Loco 2.6.11. But if you upgrade to version 2.6.12, then only English is used. If you delete the system translation and leave only the individual one, it does not help. I had to copy the individual translation into the author’s one. This action helped to return the transfer.
But I do not know if this is a good solution…
Unfortunately, Paid Memberships Pro has recently started distributing its plugin only from its website. Their plugin is available for free download only after registration on their website.
https://www.paidmembershipspro.com/membership-account/downloads/
They refused to place the plugin in the WordPress repository
Plugin Author
Tim W
(@timwhitlock)
If you delete the system translation and leave only the individual one, it does not help. I had to copy the individual translation into the author’s one.
This suggest that the individual (“custom”) translation file may itself be the problem. Please post a link to download it.
Thank you. Here is the custom translation file
Plugin Author
Tim W
(@timwhitlock)
Your file is fine, but I’ve dowloaded their plugin and can reproduce the problem.
Firstly, it’s worth mentioning that with Loco Translate disabled, translations can ONLY be loaded from the “author” location (i.e. the translation files under the plugin’s own languages subdirectory).
This could be for a bunch of reasons. They’ve tried to be clever with their text domain loading, and that has evidently broken in 6.7. However, that’s not actually our problem right now. Moving on…
Back to the difference between 2.6.11 and 2.6.12 – yes, I can reproduce this. It seems I previously had something in place to fix the above-mentioned problems, but they didn’t make it into my completely rewritten version of the custom file loader. I’m looking into a fix for this today.
Thank you very much. I will wait for the update, and now I have restored the site from a backup copy (WordPress 6.7 and plugin version 2.6.11). After the update is released, I will inform you additionally about the result. Thanks again very much.
Plugin Author
Tim W
(@timwhitlock)
I think I’ve resolved this. As I wrote in the other topic, try the dev version please. In my tests with your plugin, it does seem to fix the issue.
The root cause is that the developer of your plugin calls load_textdomain
directly with its custom paths. This is not good practice, but worked previously, because Loco Translate listened on a filter which has been removed from WordPress 6.7. Hence I removed it from my plugin too.
Ironically it was still working with the old loader even under 6.7, because your plugin is “manually” applying this filter themselves as part of their convoluted text domain loader. I hadn’t considered that, and I expect a lot of plugins will do stuff like this, so the fix is good and will stay in place.
Please mark the topic as resolved as soo as you can verify the dev version fixes your issue. I’d like to release it as 2.6.13 as soon as possible to stop the flood of emails. Thanks.
Thank you. I will give you an answer within 1 hour.
I checked it out. Everything is working well. I just downloaded the dev version and installed it on top of version 2.6.11. Everything works. Thanks!
Plugin Author
Tim W
(@timwhitlock)
Thanks. I’m going to release 2.6.13 momentarily. Normally I’d wait longer, but it seems necessary under the circumstances.