Hi @fresco, once you’ve saved the change does the theme change on the front end of the website? i.e. If you select, for example, “Le Frog” and save, do the tabs/accordions on the front end appear in a green style, or are you just getting the base styles only?
What happens if you delete or move the jQuery UI custom theme elsewhere so that Squelch Tabs and Accordions can no longer see it?
Have you got any other plugins installed? Does the change take effect correctly if you disable the other plugins on the site?
What about if you switch to a different WordPress theme? One of the default themes such as Twenty Twenty Four would be the best choice.
Can you also please confirm which version of the plugin you have installed, which version of WordPress you’re running, which WordPress theme you’re using, and which version of jQuery UI custom theme you have rolled.
Oh … a couple of other thoughts cross my mind too:
- Which web browser are you using?
- Do you have any add-ons installed in your browser? What happens if you try a different web browser?
Hi @fresco,
I’ve been looking through the code for hints and I think I might know what your issue is … which language is your site using?
Hi Matt, thanks very much for the quick response, it’s much appreciated. Sorry to make work for you – all I was looking to do was to change the colour of the active accordion section from blue to my site’s yellow colour.
Anyway, here’s the details you mention:
# The main thing is that any changes to the plugin settings won’t “Save” – when I try to do so after changing the jQuery UI theme or to Disable Magic URLs, the page simply reloads and returns to the default, the front-end remains as before.
# On my sandbox site I’ve done a fresh install of the plugin, with no custom theme setup to muddy the waters, and it behaves the same way – “Save” won’t work.
# I see no difference to the “Save” function not working, whether other plugins are Active or not.
# If I switch to the Twenty Twenty Four theme changes to the plugin settings still won’t “Save”.
# It’s the latest version of the plugin that’s being used, 0.4.6, on WordPress 6.5, and it’s a heavily customised (mostly using CSS) version of the Newspaper theme by tagdiv, and I used the recommendations in the plugin documentation for rolling the theme to 1.13.2.
# This unable to “Save” issue is present whether I use Safari v17.4.1 or Chrome v123.0.6312.107.
# Both my live site and my sandbox site are set to use “English (UK)”. If I switch to “English (United States)” and refresh the cache etc. it makes no difference to the plugin “Save” settings behaviour, unfortunately.
Hi @fresco,
Both my live site and my sandbox site are set to use “English (UK)”. If I switch to “English (United States)” and refresh the cache etc. it makes no difference to the plugin “Save” settings behaviour, unfortunately.
You’re using a cache? Is that a web cache in front of your website (such as Nginx or Varnish) or a caching plugin (such as WP-Rocket or W3 Total Cache)?
Also, one other thing, could you confirm to me the exact words on the “Save” button? It should say exactly this:
Save Changes
That exact capitalisation, those exact words. If something is changing that then the save won’t work (due to a bug I just discovered while looking into this for you).
Hey, thanks Matt.
# When I said ‘cache’ I just meant the browser cache. I have already disabled the WP SuperCache plugin when I started to troubleshoot this issue.
# Interestingly, my button says “Save changes”, lower case ‘c’….
# Interestingly, my button says “Save changes”, lower case ‘c’….
Okay, that’s definitely the problem then. Your site’s pulled in the translated string which is capitalised slightly differently. The admin screen is ancient and, until recently, was un-translateable. That changed a few versions back but I see in the code that it’s checking what the text on the button is and refusing to save if that text isn’t exactly Save Changes. I translated the plugin into the English (UK) locale, using “Save Changes” but I can now see that the editor rejected my translation and used their own translation of “Save changes”, which then triggers the bug.
I’ll release a fix for that ASAP as it’ll be affecting all users in the UK (including me!) but there’s a better solution coming soon as all of these settings are going to move into the Customiser.
Your current workarounds are:
- If you know how to use your browser’s developer tools you can edit the text on the button to change the text of the button to “Save Changes”. It’s an ugly workaround but it should get you past this initial hiccup.
- Switch your site to American English, which will use the translation strings I originally authored in the plugin, thus solving the problem.
- I can also provide you with a development copy of the plugin which uses the customiser to save settings, which would also solve the problem — but then you’d be on a dev copy which wouldn’t be ideal.
- Wait until I release 0.4.7 which will have a fix for this issue.
Thanks for reporting this, by the way.
Brilliant stuff Matt, you nailed that down quickly!
I selected my rolled UI theme then changed the text of the button in Safari’s Web Inspector Elements to have the capital ‘C’ and it saved perfectly. The colours in the front-end are now as I set in the rolled theme – perfect!
I’ll just wait for when 0.4.7 is ready.
Many thanks for your great support!
I’ve just pushed out 0.4.7, please give it a go and confirm whether it solves your problem.
Hi Matt, I am happy to report that 0.4.7 works perfectly!
The text on the button is still translated with a lower-case ‘c’, but functionally it’s fixed.
Awesome stuff, thanks very much for bottoming this one out.
No problem, thanks for reporting the issue — stupid mistakes like this will cause most people to just give up!